Hi,
On 08/08/2019 15:50, Laurent Pinchart wrote:
Hi Greg,
Thank you for the patch.
On Thu, Jun 13, 2019 at 01:57:49PM +0200, Greg Kroah-Hartman wrote:
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc: Tomi Valkeinen tomi.valkeinen@ti.com Cc: David Airlie airlied@linux.ie Cc: Daniel Vetter daniel@ffwll.ch Cc: Laurent Pinchart laurent.pinchart@ideasonboard.com Cc: Sebastian Reichel sebastian.reichel@collabora.com Cc: Jyri Sarha jsarha@ti.com Cc: Tony Lindgren tony@atomide.com Cc: zhong jiang zhongjiang@huawei.com Cc: dri-devel@lists.freedesktop.org Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
This makes sense.
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Tomi, will you take this patch in your tree ?
Yes, I'll pick this up. I presume debugfs_create_file() will give a warning print if it fails to create the file, instead of being silent.
Tomi