On Mon, Jul 01, 2013 at 09:16:56PM +0100, Chris Wilson wrote:
On Mon, Jul 01, 2013 at 10:05:54PM +0200, Daniel Vetter wrote:
When converting to the preallocated drm_mm_node interfaces in
commit dc9dd7a20fde95aa81a8307cde79c2dff9f83f3d Author: Chris Wilson chris@chris-wilson.co.uk Date: Fri Dec 7 20:37:07 2012 +0000
drm/i915: Preallocate the drm_mm_node prior to manipulating the GTT drm_mmonly the allocation side was converted, but not the freeing. Fix this up.
Note that the only difference between put_block and remove_node is that the former fills up the preallocation cache. Which we don't need anyway and hence is just wasted space.
Cc: Chris Wilson chris@chris-wilson.co.uk Cc: Ben Widawsky ben@bwidawsk.net Signed-off-by: Daniel Vetter daniel.vetter@ffwll.ch
You learn something new every day. Reviewed-by: Chris Wilson chris@chris-wilson.co.uk
The lack of kfree in this patch might be a problem ...
/me tries again -Daniel