Op 27-07-17 om 17:30 schreef Daniel Vetter:
On Thu, Jul 27, 2017 at 03:45:11PM +0100, Emil Velikov wrote:
Hi Maarten
On 27 July 2017 at 13:58, Maarten Lankhorst maarten.lankhorst@linux.intel.com wrote:
drm_atomic_commit could previous have always failed when waits failed, but locking was always done uninterruptibly. Add infrastructure to make it possible for callers to choose interruptible locking, and convert the 4 most common ioctl's to use it.
All other atomic helpers can be converted when Daniel's "acquire_ctx for everyone!" patch series lands.
There's a KMS locking documentation/example in drm_modeset_lock.c. Can you please update that as well?
Not sure what we should update there? As-is it still works for the non-interruptible case. Or do you mean we should have an interruptible variant of it too?
Anyway, with the testcase added also for cursor and plane code, patches 4&5 also get my Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch
Any reason you didn't convert the set_config path too? That's probably the one most will be stuck in when something goes wrong ... Another one is the various get* and setprop calls (but the later needs my patch series first). -Daniel
I only did the ones I expect to be called most often by frequency. The atomic ioctl, pageflip, cursor update and setplane for overlays are likely to be done most. I think we could test all additions like that, perhaps even the interruptible backoff case, at least for the atomic ioctl. :)