Hi,
On Tue, Sep 14, 2021 at 9:26 AM Doug Anderson dianders@google.com wrote:
Hi,
On Mon, Sep 13, 2021 at 8:23 PM yangcong yangcong5@huaqin.corp-partner.google.com wrote:
Compared to v5, squash this with patch #3 in the series in drm/panel: boe-tv101wum-nl6
yangcong (4): drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail dt-bindings: drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail drm/panel: support for BOE and INX video mode panel dt-bindings: boe, tv101wum-n16: Add compatible for boe tv110c9m-ll3 and inx hj110iz-01a
.../display/panel/boe,tv101wum-nl6.yaml | 7 + .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 745 +++++++++++++++++- 2 files changed, 750 insertions(+), 2 deletions(-)
Still seems OK to me and you carried my Reviewed-by over which is fine with me.
Just to give others time to chime in, I'll reset my snooze and wait another couple weeks. If I don't hear anything then I'll work on landing.
OK, my snooze came back and nobody said anything. As promised I've pushed to drm-misc-next:
93ee1a2c0f08 drm/panel: support for BOE and INX video mode panel 76d364d81b55 dt-bindings: boe, tv101wum-n16: Add compatible for boe tv110c9m-ll3 and inx hj110iz-01a 18c58153b8c6 drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail c43da06c24a4 dt-bindings: drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
I made some small changes when applying and I've noted them in the commit messages. Summary here:
1. In the compatible string "inx," should have been "innolux,". The later is what's documented for Innolux in:
Documentation/devicetree/bindings/vendor-prefixes.yaml
...neither Rob nor I noticed at review time but dim apply-branch yelled and it was obvious what the fix was. I kept Rob's Ack in place.
2. I swapped the order of bindings and code. Bindings are supposed to land first.
3. I fixed two whitespace issues (removed blank lines) as reported by dim apply-branch.
-Doug