On 2021-07-02 at 11:46:41 +0100, Matthew Auld wrote:
The block here can't be NULL, especially since we already dereferenced it earlier, so remove the redundant check.
igt_check_blocks() warn: variable dereferenced before check 'block' (see line 126)
Reported-by: Dan Carpenter dan.carpenter@oracle.com Signed-off-by: Matthew Auld matthew.auld@intel.com
drivers/gpu/drm/i915/selftests/i915_buddy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_buddy.c b/drivers/gpu/drm/i915/selftests/i915_buddy.c index f0f5c4df8dbc..d61ec9c951bf 100644 --- a/drivers/gpu/drm/i915/selftests/i915_buddy.c +++ b/drivers/gpu/drm/i915/selftests/i915_buddy.c @@ -166,10 +166,8 @@ static int igt_check_blocks(struct i915_buddy_mm *mm, igt_dump_block(mm, prev); }
- if (block) {
pr_err("bad block, dump:\n");igt_dump_block(mm, block);- }
- pr_err("bad block, dump:\n");
- igt_dump_block(mm, block);
LGTM.
Reviewed-by: Ramalingam C ramalingam.c@intel.com
return err; } -- 2.26.3