Re: [PATCH v6 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight

Hi, Daniel:

Daniel Thompson daniel.thompson@linaro.org 於 2021年3月29日 週一 下午6:26寫道：

On Sun, Mar 28, 2021 at 11:24:19PM +0800, cy_huang wrote:

...

From: ChiYuan Huang cy_huang@richtek.com

Adds support for Richtek RT4831 backlight.

Signed-off-by: ChiYuan Huang cy_huang@richtek.com

since v6

• Fix Kconfig typo.
• Remove internal mutex lock.
• Add the prefix for max brightness.
• rename init_device_properties to parse_backlight_properties.
• Remove some warning message if default value is adopted.
• Add backlight property scale to LINEAR mapping.
• Fix regmap get to check NULL not IS_ERR.

---

drivers/video/backlight/Kconfig | 8 ++ drivers/video/backlight/Makefile | 1 + drivers/video/backlight/rt4831-backlight.c | 203 +++++++++++++++++++++++++++++ 3 files changed, 212 insertions(+) create mode 100644 drivers/video/backlight/rt4831-backlight.c

diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index d83c87b..de96441 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -289,6 +289,14 @@ config BACKLIGHT_QCOM_WLED If you have the Qualcomm PMIC, say Y to enable a driver for the WLED block. Currently it supports PM8941 and PMI8998.

+config BACKLIGHT_RT4831

• tristate "Richtek RT4831 Backlight Driver"
  

• depends on MFD_RT4831
  

• help
  

•   This enables support for Richtek RT4831 Backlight driver.
  

•   It's common used to drive the display WLED. There're four channels
  

Nitpicking but I was expecting the original typo be converted to "commonly".

OK, I'll correct this typo in v7 next. And will merge the reviewed-by line. Thx.

With that addressed: Reviewed-by: Daniel Thompson daniel.thompson@linaro.org

Daniel.