Re: [PATCH 13/64] drm/vc4: hvs: Protect device resources after removal

Hi,

On Tue, Jun 14, 2022 at 05:59:15PM +0100, Dave Stevenson wrote:

...

...

@@ -132,14 +139,18 @@ static int vc4_hvs_upload_linear_kernel(struct vc4_hvs *hvs, struct drm_mm_node *space, const u32 *kernel) {

•   int ret, i;
  

•   struct drm_device *drm = hvs->dev;
  

•   int idx, ret, i;
    u32 __iomem *dst_kernel;
  
  

•   if (!drm_dev_enter(drm, &idx))
  

•           return -ENODEV;
  

vc4_hvs_upload_linear_kernel is only called from vc4_hvs_bind, so unless bind and unbind calls can be concurrent, then there's no need for protection here.

Indeed. I've removed those changes and added a comment

Thanks! Maxime