Hi Andreas,
On Sun, Nov 1, 2020 at 1:47 PM Andreas Schwab schwab@linux-m68k.org wrote:
On Nov 01 2020, Sam Ravnborg wrote:
On Sun, Nov 01, 2020 at 11:29:41AM +0100, Geert Uytterhoeven wrote:
The horizontal resolution (640) for the TT High video mode (1280x960) is definitely bogus. While fixing that, correct the timings to match the TTM195 service manual.
Signed-off-by: Geert Uytterhoeven geert@linux-m68k.org
Untested on actual hardware, hence the RFC.
v2:
- Use correct base.
drivers/video/fbdev/atafb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c index f253daa05d9d3872..5ecf3ec9f94cb720 100644 --- a/drivers/video/fbdev/atafb.c +++ b/drivers/video/fbdev/atafb.c @@ -495,8 +495,8 @@ static struct fb_videomode atafb_modedb[] __initdata = { "tt-mid", 60, 640, 480, 31041, 120, 100, 8, 16, 140, 30, 0, FB_VMODE_NONINTERLACED | FB_VMODE_YWRAP }, {
/* 1280x960, 29 kHz, 60 Hz (TT high) */"tt-high", 57, 640, 960, 31041, 120, 100, 8, 16, 140, 30,
/* 1280x960, 72 kHz, 72 Hz (TT high) */"tt-high", 57, 1280, 960, 7761, 260, 60, 36, 4, 192, 4, 0, FB_VMODE_NONINTERLACED | FB_VMODE_YWRAPWell-spotted. The change of 640 => 1280 is surely right.
TBH, I spotted that 7 years ago, but never got to looking up and calculating the other values...
I have a harder time understanding why the change of pixclock from 31041 to 7761 is correct. All other modes have a pixclock close to or equal to 32000 - so it looks strange this one is off.
32000 ps is 31.25 MHz. Looks like these are bogus, too, and only the VGA and Falcon video modes are correct?
According to the Profibuch the pixclock should be about 95000.
95 ns? That's a 10.5 MHz pixel clock? Definitely too low. The TTM195 manual says 128.85 MHz.
Gr{oetje,eeting}s,
Geert