On Sat, Feb 15, 2020 at 9:08 PM Sam Ravnborg sam@ravnborg.org wrote:
Hi Daniel.
I also checked private_flags - it is used in a few modules. And it looked legit.
Iirc i915 used this, before we went full overdrive with entire atomic state structure subclassing :-)
$ git grep -l private_flags gma500/psb_intel_drv.h i915/display/intel_display.c i915/display/intel_display_types.h i915/display/intel_tv.c i915/display/vlv_dsi.c i915/i915_irq.c msm/disp/dpu1/dpu_encoder.c msm/disp/dpu1/dpu_trace.h <= false hit
i915 still has a few uses of private_flags. Likewise msm and gma500
Looks doable to address this, but not on my TODO list.
Oh I meant the private pointer, not the flags stuff. And yeah maybe we could add this as a todo, at least for i915 and msm. For gma500 first step would be converting that driver over to atomic, which I don't think will happen. -Daniel
SamReviewed-by: Daniel Vetter daniel.vetter@ffwll.ch
Thanks - applied.
Sam