On 20/06/2022 05:07, szuni chen wrote:
Dear Krzysztof,
Thank you for the valuable command.
Krzysztof Kozlowski krzysztof.kozlowski@linaro.org 於 2022年6月17日 週五 清晨5:09寫道：
On 13/06/2022 04:11, ChiaEn Wu wrote:
From: ChiYuan Huang cy_huang@richtek.com
Add Mediatek mt6370 current sink type LED indicator binding documentation.
Signed-off-by: ChiYuan Huang cy_huang@richtek.com
.../leds/mediatek,mt6370-indicator.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml new file mode 100644 index 000000000000..42b96c8047a3 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: LED driver for MT6370 PMIC from MediaTek Integrated.
+maintainers:
- Alice Chen alice_chen@richtek.com
+description: |
- This module is part of the MT6370 MFD device.
- Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode
+properties:
- compatible:
- const: mediatek,mt6370-indicator
- "#address-cells":
- const: 1
- "#size-cells":
- const: 0
+patternProperties:
- "^(multi-)?led@[0-3]$":
If this is multi-led, then you should reference /schemas/leds/leds-pwm-multicolor.yaml
See other examples using it.
In my opinion, leds-pwm-multicolor.yaml is used for external pwm signals, and needs to assign an external pwm property. But our pwm leds use an internal clock to generate the pwm signal. Is leds-class-multicolor.yaml more appropriate?
Yeah, I meant the latter but pasted wrong file. /schemas/leds/leds-class-multicolor.yaml#
Best regards, Krzysztof