On Wednesday 03 November 2010, Pekka Enberg wrote:
On Tue, Nov 2, 2010 at 3:21 AM, Pavel Machek pavel@ucw.cz wrote:
Hi!
@@ -79,6 +79,10 @@ static struct drm_driver driver = {
static int __init i810_init(void) {
if (num_present_cpus() > 1) {pr_err("drm/i810 does not support SMP\n");return -EINVAL;} driver.num_ioctls = i810_max_ioctl; return drm_init(&driver);Umm, and now someone onlines second cpu?
Well, I see it's being fixed in a different way but yeah, num_possible_cpus() would be more appropriate here.
(trimming Cc list again)
I thought that patch was still current, what other way are we fixing it now?
Since I'm planning to do one more series for 2.6.37 to take care of the remaining BKL users, should I push the patch above plus the one that marks the module as "depends on !PREEMPT || BROKEN", or should that go through the DRM tree?
Pavel: The only board that has this chipset with multiple sockets is for Pentium III and does not have hotplug sockets, so num_present_cpus is the same as num_possible_cpus here. I can change it to num_possible_cpus of course.
Arnd