Re: [PATCH 0/3] RFC: Common functions for GEM offset creation

On Mon, 18 Jul 2011 19:20:56 -0500, Rob Clark rob@ti.com wrote:

In the process of adding GEM support for OMAP DRM driver, I noticed that I was adding code for creating/freeing mmap offsets which was virtually identical to what was already duplicated in i915 and gma500 drivers.

Rather than duplicating the code a 3rd time, it seemed like a good idea to move it to the GEM core.

Note that I don't actually have a way to test psb or i915, but the changes seem straightforward enough.

My only concern is that for the common functions the mmap_offset to create should be passed in a parameter, so that we could support more than one mapping for an object. -Chris