Hi CK,
Thanks for the review.
On Mon, 2022-03-14 at 18:08 +0800, CK Hu wrote:
Hi, Nancy:
On Fri, 2022-03-11 at 09:55 +0800, Nancy.Lin wrote:
MT8195 have two mmsys. Modify drm for MT8195 multi-mmsys support. The two mmsys (vdosys0 and vdosys1) will bring up two drm drivers, only one drm driver register as the drm device. Each drm driver binds its own component. The last bind drm driver allocates and registers the drm device to drm core. Each crtc path is created with the corresponding drm driver data.
Signed-off-by: Nancy.Lin nancy.lin@mediatek.com Reviewed-by: AngeloGioacchino Del Regno < angelogioacchino.delregno@collabora.com>
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 24 +- drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 3 +- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 300 ++++++++++++++++++--
drivers/gpu/drm/mediatek/mtk_drm_drv.h | 10 +- 4 files changed, 246 insertions(+), 91 deletions(-)
[snip]
static const struct mtk_mmsys_driver_data mt8195_vdosys0_driver_data = { .main_path = mt8195_mtk_ddp_main, .main_len = ARRAY_SIZE(mt8195_mtk_ddp_main),
- .mmsys_dev_num = 2,
After apply this patch, vdosys0 only would not work. So I think this should be set to 1 in this patch, and set to 2 in the patch that support mt8195 vdosys1. With this modification,
Reviewed-by: CK Hu ck.hu@mediatek.com
OK, I will fix it.
Regards, Nancy
};