On Tue, Jul 26, 2016 at 12:06 PM, ville.syrjala@linux.intel.com wrote:
From: Ville Syrjälä ville.syrjala@linux.intel.com
Moving the clipped plane coordinates into drm_plane_state has been discussed a few times, but as no patches seems to have materialized, I decoded to do it myself. I also added a new helper function like drm_plane_helper_check_update() that takes a plane state instead.
I converted i915, rockchip, and mediatek over to the new stuff. rockchip already looked pretty solid, mediatek had some bugs in there that I hopefully fixed. The rest of the non-x86 drivers seem to entirely lack any plane clipping code, so I decided that I don't care enough to write it from scratch. I also converted drm_simple_kms_helper, but there are no drivers using it so far.
I've only actually tested i915, the rest are just compile tested.
Entire series available here: git://github.com/vsyrjala/linux.git plane_state_rects
Ville Syrjälä (9): drm: Warn about negative sizes when calculating scale factor drm: Store clipped src/dst coordinatee in drm_plane_state drm/plane-helper: Add drm_plane_helper_check_state() drm/i915: Use drm_plane_state.{src,dst,visible} drm/i915: Use drm_plane_helper_check_state() drm/rockchip: Use drm_plane_state.{src,dst} drm/rockchip: Use drm_plane_helper_check_state() drm/mediatek: Use drm_plane_helper_check_state() drm/simple_kms_helper: Use drm_plane_helper_check_state()
Looks good to me, all patches have been reviewed.
It seems like the only consumer of drm_plane_helper_check_update() left is armada. Are you planning on converting it as well? Then we can nuke the function.
Sean
drivers/gpu/drm/drm_plane_helper.c | 136 +++++++++++++++++++++------ drivers/gpu/drm/drm_rect.c | 2 +- drivers/gpu/drm/drm_simple_kms_helper.c | 27 ++---- drivers/gpu/drm/i915/intel_atomic_plane.c | 18 +--- drivers/gpu/drm/i915/intel_display.c | 140 ++++++++++++++-------------- drivers/gpu/drm/i915/intel_drv.h | 3 - drivers/gpu/drm/i915/intel_fbc.c | 12 +-- drivers/gpu/drm/i915/intel_pm.c | 60 ++++++------ drivers/gpu/drm/i915/intel_sprite.c | 94 ++++++++++--------- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 72 ++++---------- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 31 ++---- include/drm/drm_crtc.h | 13 +++ include/drm/drm_plane_helper.h | 5 + 13 files changed, 315 insertions(+), 298 deletions(-)
-- 2.7.4
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel