Re: [PATCH v2 12/15] drm/mgag200: Remove out-commented suspend/resume helpers

Hi

Am 12.05.20 um 12:14 schrieb Emil Velikov:

Hi Thomas,

On Tue, 12 May 2020 at 09:43, Thomas Zimmermann tzimmermann@suse.de wrote:

...

The suspend/resume helpers are unused. Also remove associated state from struct mga_device.

Although DPMS in it's traditional sense is no longer a thing, would it make sense to keep this around for documentation purposes? In particular, the pci magic and associated PLL/DAC/pixel clock could be used for dynamic PM.

That patch is not about DPMS. The DPMS code is still there. The suspend/resume helpers were outcommented and I don't know if they ever worked. Let's remove them.

Best regards Thomas

-Emil