Hi Russell,
Thanks for your comments!
On Fri, Oct 29, 2021 at 10:08 AM Russell King (Oracle) linux@armlinux.org.uk wrote:
On Thu, Oct 28, 2021 at 08:04:48PM -0500, Rob Herring wrote:
On Thu, Oct 21, 2021 at 03:18:53PM +0200, Geert Uytterhoeven wrote:
- properties:
port@0:type: objectdescription: FIXMELooks like the input from the example
port@1:type: objectdescription: FIXMEPresumably the output to connector or another bridge.
This is changing the binding. The original had:
Required node:
- port: Input port node with endpoint definition, as described in Documentation/devicetree/bindings/graph.txt
Indeed, cfr. "Add ports hierarchy, as an alternative to port." in the patch description. Some users use port, other use ports with one or two port subnodes.
The above change appears to require that tda998x now has two ports.
No, you can still use port:
+oneOf: + - required: + - port + - required: + - ports
When using ports, no further requirements are set, but perhaps port@0 should be made required in that case?
This goes against current usage in DT and the example.
The original example didn't even have the original required input port node, so it was incomplete.
arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts has two port subnodes. Is that wrong?
Thanks!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds