On Sat, Feb 22, 2020 at 5:21 AM Sam Ravnborg sam@ravnborg.org wrote:
Hi Kevin.
On Fri, Feb 21, 2020 at 03:48:51PM +0800, Kevin Tang wrote:
From: Kevin Tang kevin.tang@unisoc.com
The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem
Cc: Orson Zhai orsonzhai@gmail.com Cc: Baolin Wang baolin.wang@linaro.org Cc: Chunyan Zhang zhang.lyra@gmail.com Signed-off-by: Kevin Tang kevin.tang@unisoc.com
.../devicetree/bindings/display/sprd/drm.yaml | 38 ++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/sprd/drm.yaml
diff --git a/Documentation/devicetree/bindings/display/sprd/drm.yaml b/Documentation/devicetree/bindings/display/sprd/drm.yaml new file mode 100644 index 0000000..1614ca6 --- /dev/null +++ b/Documentation/devicetree/bindings/display/sprd/drm.yaml @@ -0,0 +1,38 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/sprd/drm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Unisoc DRM master device
+maintainers:
- David Airlie airlied@linux.ie
- Daniel Vetter daniel@ffwll.ch
- Rob Herring robh+dt@kernel.org
- Mark Rutland mark.rutland@arm.com
Rob is king of a super-maintainer. He should not be listed unless he has special relations to sprd. David + Daniel - likewise. Unless they are closely related to sprd drop them.
+description: |
- The Unisoc DRM master device is a virtual device needed to list all
- DPU devices or other display interface nodes that comprise the
- graphics subsystem.
I wonder why you name it "Unisoc" when all other places references sprd.
sprd is abbreviation for Spreadtrum who was acquired by Unigroup and combined with another company RDA into Unisoc recently. Unfortunately these 2 companies already have had their vendor prefix in kernel tree as sprd and rda for each. So far each of their prefix is kept unchanging.
-Orson
+properties:
- compatible:
- const: sprd,display-subsystem
- ports:
- description:
Should contain a list of phandles pointing to display interface portof DPU devices.+required:
- compatible
- ports
So you want to force the driver to support ports - and no panel referenced directly?
+examples:
- |
- display-subsystem {
compatible = "sprd,display-subsystem";ports = <&dpu_out>;- };
\ No newline at end of file
Please fix.
Sam