Hi David Airlie，
Please help to confirm whether this modification is reasonable when you are free, thanks.
在 2020/8/13 14:31, Huang Jiachai 写道:
ping...
在 2020/7/23 3:01, Heiko Stübner 写道:
Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang:
don't mask possible_crtcs if remote-point is disabled.
Signed-off-by: Sandy Huang hjc@rock-chips.com
Reviewed-by: Heiko Stuebner heiko@sntech.de
changes in v2:
- drop additional of_node_put, as ep will be put with the next
iteration of for_each_endpoint_of_node()
As this touches a pretty central function is there something to keep in mind in regards to other DRM drivers? [question for the broader audience ;-) ]
Heiko
drivers/gpu/drm/drm_of.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index fdb05fbf72a0..565f05f5f11b 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev, uint32_t possible_crtcs = 0; for_each_endpoint_of_node(port, ep) { + if (!of_device_is_available(ep)) + continue;
remote_port = of_graph_get_remote_port(ep); if (!remote_port) { of_node_put(ep);