Re: [PATCH v3 13/13] video: fbdev: sis: Drop useless call to SiS_GetResInfo()

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

Coverity reported:

 Useless call (USELESS_CALL) side_effect_free: Calling
  SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex) is only useful for its
 return value, which is ignored.

And this is correct - so drop the call.

Signed-off-by: Sam Ravnborg sam@ravnborg.org Reported-by: Colin Ian King colin.king@canonical.com Addresses-Coverity: ("Useless call") Cc: Colin Ian King colin.king@canonical.com Cc: Thomas Winischhofer thomas@winischhofer.net

Acked-by: Thomas Zimmermann tzimmermann@suse.de

---

drivers/video/fbdev/sis/init.c | 1 - 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c index b77ea1a8825a..b568c646a76c 100644 --- a/drivers/video/fbdev/sis/init.c +++ b/drivers/video/fbdev/sis/init.c @@ -2659,7 +2659,6 @@ SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo, if(SiS_Pr->UseCustomMode) { infoflag = SiS_Pr->CInfoFlag; } else {

•  SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex);
    if(ModeNo > 0x13) {
  

  infoflag = SiS_Pr->SiS_RefIndex[RRTI].Ext_InfoFlag; }