On Sat, 2013-02-09 at 19:59 +0100, Daniel Vetter wrote:
On Sat, Feb 09, 2013 at 05:27:36PM +0200, Imre Deak wrote:
So far we created a sparse dma scatter list for gem objects, where each scatter list entry represented only a single page. In the future we'll have to handle compact scatter lists too where each entry can consist of multiple pages, for example for objects imported through PRIME.
The previous patches have already fixed up all other places where the i915 driver _walked_ these lists. Here we have the corresponding fix to _create_ compact lists. It's not a performance or memory footprint improvement, but it helps to better exercise the new logic.
Reference: http://www.spinics.net/lists/dri-devel/msg33917.html Signed-off-by: Imre Deak imre.deak@intel.com
Just a quick question: Have you checked with printks or so that we indeed create such coalesced sg entries every once in a while?
Yes, quite often that was the case, so we at least are really testing the thing..