Hey Hsin-Yi,
Thanks for catching this.
checkpatch --strict is throwing an error for this patch. With that, feel free to add my r-b.
Reviewed-by: Robert Foss robert.foss@linaro.org
On Fri, 12 Nov 2021 at 12:24, Hsin-Yi Wang hsinyi@chromium.org wrote:
edid_read() was assumed to return 0 on success. After 7f16d0f3b8e2("drm/bridge: anx7625: Propagate errors from sp_tx_rst_aux()"), the function can return >= 0 for successful case. Fix the g_edid_break condition in sp_tx_edid_read().
Fixes: 7f16d0f3b8e2("drm/bridge: anx7625: Propagate errors from sp_tx_rst_aux()") Signed-off-by: Hsin-Yi Wang hsinyi@chromium.org
drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 1a871f6b6822ee..392203b576042b 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -826,7 +826,7 @@ static int sp_tx_edid_read(struct anx7625_data *ctx, g_edid_break = edid_read(ctx, offset, pblock_buf);
if (g_edid_break)
if (g_edid_break < 0) break; memcpy(&pedid_blocks_buf[offset],-- 2.34.0.rc1.387.gb447b232ab-goog