Re: [PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

Quoting Manasi Navare (2018-07-31 22:07:06)

•   /* PPS 4 */
  

•   pps_sdp->pps_payload.pps_4 = (u8)((dsc_cfg->bits_per_pixel &
  

•                                      DSC_PPS_BPP_HIGH_MASK) >>
  

•                                     DSC_PPS_MSB_SHIFT) |
  

To avoid overhanging cliffs, insert the newline after the sequence point. Quite a few examples throughout the series that would benefit from more judicial placement of line breaks.

•           (u8)dsc_cfg->vbr_enable << DSC_PPS_VBR_EN_SHIFT |
  

•           (u8)dsc_cfg->enable422 << DSC_PPS_SIMPLE422_SHIFT |
  

•           (u8)dsc_cfg->convert_rgb << DSC_PPS_CONVERT_RGB_SHIFT |
  

•           (u8)dsc_cfg->block_pred_enable << DSC_PPS_BLOCK_PRED_EN_SHIFT;
  

Furthermore, you only need the SPDX shorthand rather than full licence text. -Chris