Re: [PATCH] drm/v3d: Use kvcalloc

On Sat, 2022-03-12 at 07:26 -0800, Harshit Mogalapalli wrote:

kvcalloc is same as kvmalloc_array + __GFP_ZERO.

[]

diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c

[]

@@ -308,9 +308,8 @@ v3d_lookup_bos(struct drm_device *dev, return -EINVAL; }

• job->bo = kvmalloc_array(job->bo_count,

• 		 sizeof(struct drm_gem_cma_object *),
  

• 		 GFP_KERNEL | __GFP_ZERO);
  

• job->bo = kvcalloc(job->bo_count, sizeof(struct drm_gem_cma_object *),

• 	   GFP_KERNEL);
  

  if (!job->bo) { DRM_DEBUG("Failed to allocate validated BO pointers\n"); return -ENOMEM;

trivia:

The DRM_DEBUG could also be removed as the the alloc will do a a dump_stack on failure.