Re: [RFC 4/6] drm: simpledrm: add fbdev fallback support

On 06/24/2013 04:27 PM, David Herrmann wrote:

Create a simple fbdev device during SimpleDRM setup so legacy user-space and fbcon can use it.

fbdev deletion is quite buggy. A unregister_framebuffer() call followed by a printk() causes NULL-derefs in hide_cursor() and other places in the VT layer. Hence, we leak the fbdev device currently to make the VT layer happy. This needs to be fixed soon! Otherwise, we need a "depends !VT" line for SimpleDRM.

diff --git a/drivers/gpu/drm/simpledrm/Makefile b/drivers/gpu/drm/simpledrm/Makefile

simpledrm-y := simpledrm_drv.o simpledrm_main.o simpledrm_mem.o

+ifdef CONFIG_DRM_SIMPLEDRM_FBDEV

• simpledrm-y += simpledrm_fbdev.o

+endif

I think that's:

+ simpledrm-$(CONFIG_DRM_SIMPLEDRM_FBDEV) += simpledrm_fbdev.o