Re: [PATCH v5 11/29] drm/omap: dsi: pass vc to various functions

On 08/12/2020 17:38, Laurent Pinchart wrote:

Hi Tomi,

Thank you for the patch.

On Tue, Dec 08, 2020 at 02:28:37PM +0200, Tomi Valkeinen wrote:

...

To start fixing the issues related to channels and vcs described in the previous commit, pass vc to various functions which will need it do properly handle different DSI channels and VCs.

This is a bit hard to review as you add the OMAP DSI VC as a parameter (named vc) to some functions , and the MIPI DSI virtual channel as a parameter (named channel) to other functions. Only the former matches the commit message. Splitting this in two would make the changes

Ah, that's true. I'll update the title and desc to mention channel too.

Tomi