Re: [PATCH v3] arm64: dts: qcom: sc7180: Add Display Port dt node

Quoting Tanmay Shah (2020-06-30 12:51:51)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 31b9217bb5bf..271d55db62ab 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -2440,6 +2447,44 @@ dsi_phy: dsi-phy@ae94400 {

                            status = "disabled";
                    };

•                   msm_dp: displayport-controller@ae90000{
  

•                           status = "disabled";
  

•                           compatible = "qcom,sc7180-dp";
  

•                           reg = <0 0xae90000 0 0x1400>;
  

Please use full 8 digits in address, i.e. 0x0ae90000.

•                           reg-names = "dp_controller";
  

reg-names is pretty useless here. Please remove it.

•                           interrupt-parent = <&mdss>;
  

•                           interrupts = <12 0>;
  

Please use irq flags instead of 0.

•                           clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
  

•                                    <&dispcc DISP_CC_MDSS_DP_AUX_CLK>,
  

•                                    <&dispcc DISP_CC_MDSS_DP_LINK_CLK>,
  

•                                    <&dispcc DISP_CC_MDSS_DP_LINK_INTF_CLK>,
  

•                                    <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>;
  

•                           clock-names = "core_iface", "core_aux", "ctrl_link",
  

•                                         "ctrl_link_iface", "stream_pixel";
  

•                           #clock-cells = <1>;
  

•                           assigned-clocks = <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>;
  

•                           assigned-clock-parents = <&msm_dp 1>;
  

Why don't we assign both clk parents here (&msm_dp 0) so that we don't need any clk_set_parent() calls in the code?

•                           ports {
  

•                                   #address-cells = <1>;
  

•                                   #size-cells = <0>;
  

•                                   port@0 {
  

•                                           reg = <0>;
  

•                                           dp_in: endpoint {
  

•                                                   remote-endpoint = <&dpu_intf0_out>;
  

•                                           };
  

•                                   };
  

•                                   port@1 {
  

•                                           reg = <1>;
  

•                                           dp_out: endpoint { };
  

•                                   };
  

•                           };
  

•                   };
            };
  
            dispcc: clock-controller@af00000 {