Re: [PATCH 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge

Hi Marek.

On Sat, Jul 25, 2020 at 11:14:56PM +0200, Marek Vasut wrote:

Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge, this one is used in the Raspberry Pi 7" touchscreen display unit.

Signed-off-by: Marek Vasut marex@denx.de To: dri-devel@lists.freedesktop.org Cc: Eric Anholt eric@anholt.net Cc: Rob Herring robh+dt@kernel.org Cc: Sam Ravnborg sam@ravnborg.org Cc: devicetree@vger.kernel.org

This looks like a candidate for the simple-bridge-yaml binding. Did you check if this is sufficient or we really need a new binding?

If we need a new binding then they to take a look at how simple-bridge define the ports. You can do this in a simple way than what is used here. It looks like this was copied from toshiba,tc358768.yaml, but there are better examples to follow.

Sam

---

.../display/bridge/toshiba,tc358762.yaml | 116 ++++++++++++++++++ 1 file changed, 116 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/toshiba,tc358762.yaml

diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358762.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358762.yaml new file mode 100644 index 000000000000..40098ca761a3 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358762.yaml @@ -0,0 +1,116 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/toshiba,tc358762.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Toshiba TC358762 MIPI DSI to MIPI DPI bridge

+maintainers:

• • Marek Vasut marex@denx.de

+description: |

• The TC358762 is bridge device which converts MIPI DSI to MIPI DPI.

+properties:

• compatible:
• enum:

•  - toshiba,tc358762
  

• reg:
• maxItems: 1
• description: virtual channel number of a DSI peripheral
• vddc-supply:
• description: Regulator for 1.2V internal core power.
• ports:
• type: object
• properties:

•  "#address-cells":
  

•    const: 1
  

•  "#size-cells":
  

•    const: 0
  

•  port@0:
  

•    type: object
  

•    additionalProperties: false
  

•    description: |
  

•      Video port for MIPI DSI input
  

•    properties:
  

•      reg:
  

•        const: 0
  

•    patternProperties:
  

•      endpoint:
  

•        type: object
  

•        additionalProperties: false
  

•        properties:
  

•          remote-endpoint: true
  

•    required:
  

•      - reg
  

•  port@1:
  

•    type: object
  

•    additionalProperties: false
  

•    description: |
  

•      Video port for MIPI DPI output (panel or connector).
  

•    properties:
  

•      reg:
  

•        const: 1
  

•    patternProperties:
  

•      endpoint:
  

•        type: object
  

•        additionalProperties: false
  

•        properties:
  

•          remote-endpoint: true
  

•    required:
  

•      - reg
  

• required:

•  - "#address-cells"
  

•  - "#size-cells"
  

•  - port@0
  

•  - port@1
  

+required:

• • compatible
• • reg
• • vddc-supply
• • ports

+additionalProperties: false

+examples:

• • |
• bridge@0 {

•    reg = <0>;
  

•    compatible = "toshiba,tc358762";
  

•    vddc-supply = <&vcc_1v2_reg>;
  

•    #address-cells = <1>;
  

•    #size-cells = <0>;
  

•    port@0 {
  

•        reg = <0>;
  

•        bridge_in: endpoint {
  

•            remote-endpoint = <&dsi_out>;
  

•        };
  

•    };
  

•    port@1 {
  

•        reg = <1>;
  

•        bridge_out: endpoint {
  

•            remote-endpoint = <&panel_in>;
  

•        };
  

•    };
  

• };

-- 2.27.0