6 Mar
2019
6 Mar
'19
4:13 a.m.
I don't think you need the _pad fields here, and they're actually a bad idea because the lack of checking in your ioctls means you can't trust that userspace has initialized them to 0 when you want to redefine them as a flags field later.
Could I drop the _pad? I thought there is a rule that all drm ioctl arg size should be kept 64bit, is there?
Keep them but check in the driver that they are 0.
Dave.