Re: [PATCH v4 2/3] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

Hi,

On Thu, Mar 17, 2022 at 6:13 AM Kieran Bingham kieran.bingham+renesas@ideasonboard.com wrote:

From: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com

Implement the bridge connector-related .get_edid() operation, and report the related bridge capabilities and type.

Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com Signed-off-by: Kieran Bingham kieran.bingham+renesas@ideasonboard.com Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com

---

Changes since v1:

• The connector .get_modes() operation doesn't rely on EDID anymore, __ti_sn_bridge_get_edid() and ti_sn_bridge_get_edid() got merged together
• Fix on top of Sam Ravnborg's DRM_BRIDGE_STATE_OPS

Changes since v2: [Kieran]

• Only support EDID on DRM_MODE_CONNECTOR_DisplayPort modes.

Changes since v3: [Kieran]

• Remove PM calls in ti_sn_bridge_get_edid() and simplify

drivers/gpu/drm/bridge/ti-sn65dsi86.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)

Looks good to me now.

Reviewed-by: Douglas Anderson dianders@chromium.org