On Sun, Dec 06, 2020 at 08:02:34PM +0100, Sam Ravnborg wrote:
Following the great work of Lee Jones in other subsystems here is a set of patches that address all remaining W=1 warnings in drivers/video/. Lee Jones already fixed all warnings in video/backlight/ so this is mostly fbdev related fixes.
The general approach used were:
- Fix kernel-doc, this is often very trivial
- Drop unused local variables
Build tested on a set of architectures with various configs.
The patches do not depend on each other and fixes for one driver are kept in a single patch.
v2:
- Updated subject of the patches to tell what was fixed (Lee)
- Fixed build error in one patch (kernel test robot)
- A few editorials updates to the changelog messages
v3:
- Applied patches that was acked - thanks Thomas!
- Updated patches after feedback from Randy and Thomas
- Added several new patches to cover warnings that triggers with other architectures than the one I used for v1 + v2
- Included one sh specific fix that handle a corner-case, let's see what the sh people say to that
- One fix to previous set of patches to fix an issue reported by Coverity (By Colin)
Sam
Sam Ravnborg (13): video: fbdev: hgafb: Fix kernel-doc warnings video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core video: fbdev: uvesafb: Fix set but not used warning sh: Fix set but not used warnings with !CONFIG_MMU video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write video: fbdev: wmt_ge_rops: Fix function not declared warnings video: fbdev: goldfishfb: Fix defined but not used warning video: fbdev: gbefb: Fix set but not used warning video: fbdev: efifb: Fix set but not used warning for screen_pitch video: fbdev: controlfb: Fix set but not used warnings video: fbdev: sis: Drop useless call to SiS_GetResInfo()
Thanks for the feedback! All applied to drm-misc-next except the sh patch.
The sh patch will be resend to the sh people as it should go in via the sh tree.
Sam