On Mon, Feb 11, 2013 at 7:33 PM, Daniel Vetter daniel.vetter@ffwll.ch wrote:
On Tue, Feb 12, 2013 at 1:24 AM, Rob Clark robdclark@gmail.com wrote:
On Thu, Jan 24, 2013 at 10:20 AM, Daniel Vetter daniel.vetter@ffwll.ch wrote:
No need to check whether we've allocated a new fb since we're not always doing that. Also, we always need to register the fbdev and add it to the panic notifier.
hmm, how is this not leading to a register_framebuffer() on every hotplug event?
drm_fb_helper_hotplug_event calls drm_fb_helper_set_par directly, so bypasses all the initial setup which I'm streamlining here. See "drm/fb-helper: directly call set_par from the hotplug handler".
doh, that's the problem with reviewing long patchset without applying them as I go..
ok, then looks good
Reviewed-by: Rob Clark robdclark@gmail.com
-Daniel
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch