Hi Bjorn
I had a quick glance on the series and before getting to other things wanted to know how you are initializing two different connectors for DP & EDP resp.
The connector type for DP should be DRM_MODE_CONNECTOR_DisplayPort and eDP should be DRM_MODE_CONNECTOR_eDP. We need both to be created so that both EDP and DP can be supported concurrently.
Will these changes work for concurrent eDP and DP case?
Thanks
Abhinav
On 2021-05-10 21:20, Bjorn Andersson wrote:
The first patch in the series is somewhat unrelated to the support, but simplifies reasoning and debugging of timing related issues.
The second patch introduces support for dealing with different register block layouts, which is used in the forth patch to describe the hardware blocks found in the SC8180x eDP block.
The third patch configures the INTF_CONFIG register, which carries the configuration for widebus handling. As with the DPU the bootloader enables widebus and we need to disable it, or implement support for adjusting the timing.
Bjorn Andersson (4): drm/msm/dp: Simplify the mvid/nvid calculation drm/msm/dp: Store each subblock in the io region drm/msm/dp: Initialize the INTF_CONFIG register drm/msm/dp: Add support for SC8180x eDP
drivers/gpu/drm/msm/dp/dp_catalog.c | 99 +++++++---------------------- drivers/gpu/drm/msm/dp/dp_display.c | 1 + drivers/gpu/drm/msm/dp/dp_parser.c | 22 +++++++ drivers/gpu/drm/msm/dp/dp_parser.h | 8 +++ 4 files changed, 53 insertions(+), 77 deletions(-)