27 Jan
2021
27 Jan
'21
8:48 a.m.
Hi Dan, Carlis,
On Wed, Jan 27, 2021 at 9:32 AM Dan Carpenter dan.carpenter@oracle.com wrote:
On Wed, Jan 27, 2021 at 02:19:27PM +0800, carlis wrote:
hi,i will fix it like below: par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0, GPIOD_IN); if (IS_ERR(par->gpio.te)) { rc = PTR_ERR(par->gpio.te); pr_err("Failed to request te gpio: %d\n", rc); par->gpio.te = NULL; }
I wish you would just copy and paste the code that I sent you instead, but this also fixes the crash...
While this fixes the crash, it does not propagate the error condition (which may be -EPROBE_DEFER) upstream. Same for devm_request_irq().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds