-----Original Message----- From: keescook@google.com [mailto:keescook@google.com] On Behalf Of Kees Cook Sent: Friday, July 28, 2017 1:16 PM To: Alex Deucher Cc: LKML; David Airlie; amd-gfx list; Maling list - DRI developers; Deucher, Alexander; Zhu, Rex; Koenig, Christian; Zhang, Hawking Subject: Re: [PATCH] drm/amd/powerplay: rv: Use designated initializers
On Thu, Jul 27, 2017 at 6:43 PM, Alex Deucher alexdeucher@gmail.com wrote:
On Tue, Jul 25, 2017 at 5:47 PM, Kees Cook keescook@chromium.org
wrote:
As done for vega10 in commit 3ddd396f6b57 ("drm/amd/powerplay: Use designated initializers") mark other tableFunction entries with designated initializers. The randstruct plugin requires designated initializers for structures that are entirely function pointers.
Cc: Rex Zhu Rex.Zhu@amd.com Cc: Hawking Zhang Hawking.Zhang@amd.com Cc: Alex Deucher alexander.deucher@amd.com Signed-off-by: Kees Cook keescook@chromium.org
If I can get an Ack for this, I'll carry it in the gcc-plugins tree, unless you think this is worth landing for v4.13, in which case, please take it now. :)
Acked-by: Alex Deucher alexander.deucher@amd.com
I'm happy to take this through my tree if that is ok with you.
Since the randstruct patch depends on this fix, it's likely best to go through my tree unless you can get this into v4.13. (Since then when the randstruct patch lands in v4.14, it'll already be there.) I'm fine either way.
Go ahead and take it through your tree. Thanks!
Alex
Thanks!
-Kees
-- Kees Cook Pixel Security