Hi Jonathan,
Thank you for the patch.
On Tue, Jun 08, 2021 at 03:53:28PM -0400, Jonathan Marek wrote:
Document a new phy-type property which will be used to determine whether the phy should operate in D-PHY or C-PHY mode.
Signed-off-by: Jonathan Marek jonathan@marek.ca
.../devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 4 ++++ include/dt-bindings/phy/phy.h | 2 ++ 2 files changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml index bf16b1c65e10..d447b517ea19 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml @@ -34,6 +34,10 @@ properties: description: | Connected to VDD_A_DSI_PLL_0P9 pin (or VDDA_DSI{0,1}_PLL_0P9 for sm8150)
- phy-type:
- description: |
D-PHY (default) or C-PHY mode: PHY_TYPE_DSI_DPHY or PHY_TYPE_DSI_CPHYrequired:
- compatible
- reg
diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h index 887a31b250a8..b978dac16bb8 100644 --- a/include/dt-bindings/phy/phy.h +++ b/include/dt-bindings/phy/phy.h @@ -20,5 +20,7 @@ #define PHY_TYPE_XPCS 7 #define PHY_TYPE_SGMII 8 #define PHY_TYPE_QSGMII 9 +#define PHY_TYPE_DSI_DPHY 10 +#define PHY_TYPE_DSI_CPHY 11
The MIPI D-PHY and C-PHY apply to both DSI and CSI. I'd name this PHY_TYPE_DPHY and PHY_TYPE_CPHY, or possibly, PHY_TYPE_MIPI_DPHY and PHY_TYPE_MIPI_CPHY, without a DSI prefix. With this addressed and the DT bindings updated accordingly,
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
(You may be asked to split this in two patches though, not sure)
#endif /* _DT_BINDINGS_PHY */