On Fri, 21 Jan 2022 at 23:44, Stephen Boyd swboyd@chromium.org wrote:
Quoting Dmitry Baryshkov (2022-01-20 23:37:45)
On Fri, 21 Jan 2022 at 07:30, Stephen Boyd swboyd@chromium.org wrote:
Quoting Dmitry Baryshkov (2022-01-19 14:16:15)
diff --git a/drivers/gpu/drm/msm/msm_io_utils.c b/drivers/gpu/drm/msm/msm_io_utils.c index 7b504617833a..5533c87c7158 100644 --- a/drivers/gpu/drm/msm/msm_io_utils.c +++ b/drivers/gpu/drm/msm/msm_io_utils.c
if (rc) {DRM_DEV_ERROR(&pdev->dev, "Failed to get clock refs %d\n", rc);return rc;}rc = of_clk_set_defaults(pdev->dev.of_node, false);Why is this needed?
Both mdss and mdp devices use assigned-clocks properties, while not being a clock provider (or a child of it). So I assumed it should call the of_clk_set_defaults(node, false)
A device node doesn't need to be a clk provider to call of_clk_set_defaults(). Does the call to of_clk_set_defaults() in drivers/base/platform.c cover this?
I'll check if it does.
Not to mention that this call exists in the msm_dss_parse_clock(), which is being refactored/replaced.
Indeed it's already in the code.
if (rc) {DRM_DEV_ERROR(&pdev->dev, "Failed to set clock defaults %d\n", rc);return rc;}*clocks = bulk;