Re: [PATCH 01/24] drm/omap: fix omap_fbdev_free() when omap_fbdev_create() wasn't called

On 27/02/18 13:28, Laurent Pinchart wrote:

Hi Tomi,

Thank you for the patch.

On Monday, 12 February 2018 11:44:31 EET Tomi Valkeinen wrote:

...

If we have no crtcs/connectors, fbdev init goes fine, but omap_fbdev_create() is never called. This means that omap_fbdev->bo is NULL and omap_fbdev_free() crashes.

Add a check to omap_fbdev_free() to handle the NULL case.

Signed-off-by: Tomi Valkeinen tomi.valkeinen@ti.com

I wonder whether we shouldn't fail probe if we have no CRTC or connector, but regardless of that, this change looks good to me.

We can use the writeback without any displays.

Tomi