Hi Harry,
On Monday 30 Jan 2017 10:38:47 Harry Wentland wrote:
On 2017-01-28 09:26 PM, Andrey Grodzovsky wrote:
Swicth to use atomic helper. Start using actual user's given target_vblank value for flip instead of current value.
v3: Update for movig pflip flags to crtc_state
Change-Id: I25dae6d8c29de5d022a42aa99a18a32674b56cda Signed-off-by: Andrey Grodzovsky Andrey.Grodzovsky@amd.com
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 - .../drm/amd/display/amdgpu_dm/amdgpu_dm_types.c | 109 +++------------ 2 files changed, 19 insertions(+), 91 deletions(-)
[snip]
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c index a443b70..148780d 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c
[snip]
@@ -2696,7 +2620,9 @@ int amdgpu_dm_atomic_commit(
* 1. This commit is not a page flip. * 2. This commit is a page flip, and targets are created. */
if (!page_flip_needed(plane_state, old_plane_state, true) ||
if (!page_flip_needed(plane_state, old_plane_state, true, crtc-state->pflip_flags)
|| action == DM_COMMIT_ACTION_DPMS_ON || action == DM_COMMIT_ACTION_SET) {Might be good to clean up indentation to conform a bit more to kernel style. Something like the following, I think (I hope Thunderbird doesn't mangle it):
if (!page_flip_needed(plane_state, old_plane_state, true, crtc->state->pflip_flags) || action == DM_COMMIT_ACTION_DPMS_ON || action == DM_COMMIT_ACTION_SET) {
In which case you should go for (tabs replaced by spaces to avoid e-mail mangling)
if (!page_flip_needed(plane_state, old_plane_state, true, crtc->state->pflip_flags) || action == DM_COMMIT_ACTION_DPMS_ON || action == DM_COMMIT_ACTION_SET) {
[snip]