Re: [RFC v2] device coredump: add new device coredump class

On Fri, Sep 5, 2014 at 10:50 AM, Johannes Berg johannes@sipsolutions.net wrote:

From: Johannes Berg johannes.berg@intel.com

Can't you just send from the correct address? ;p

(snip)

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index 4e7f0ff83ae7..134f763d90fd 100644 --- a/drivers/base/Kconfig +++ b/drivers/base/Kconfig @@ -165,6 +165,27 @@ config FW_LOADER_USER_HELPER_FALLBACK

      If you are unsure about this, say N here.

+config WANT_DEV_COREDUMP

•   bool
  

•   help
  

•     Drivers should "select" this option if they desire to use the
  

•     device coredump mechanism.
  

+config DISABLE_DEV_COREDUMP

•   bool "Disable device coredump" if EXPERT
  

•   help
  

•     Disable the device coredump mechanism despite drivers wanting to
  

•     use it; this allows for more sensitive systems or systems that
  

•     don't want to ever access the information to not have the code,
  

•     nor keep any data.
  

•     If unsure, say N.
  

+config DEV_COREDUMP

•   bool
  

•   default y if WANT_DEV_COREDUMP
  

•   depends on !DISABLE_DEV_COREDUMP
  

How about the following to avoid negative options:

config DEV_COREDUMP bool "Enable device coredump" if EXPERT default y if WANT_DEV_COREDUMP help Enable the device coredump mechanism for drivers wanting to use it. Disabling allows for more sensitive systems or systems that don't want to ever access the information to not have the code, nor keep any data.

If unsure, say Y.

Jonas