Re: [PATCH v5 3/9] drm/vc4: hdmi: Take into account the clock doubling flag in atomic_check

Hi Maxime

On Mon, 7 Dec 2020 at 15:57, Maxime Ripard maxime@cerno.tech wrote:

Reported-by: Thomas Zimmermann tzimmermann@suse.de Fixes: 63495f6b4aed ("drm/vc4: hdmi: Make sure our clock rate is within limits") Signed-off-by: Maxime Ripard maxime@cerno.tech

Reviewed-by: Dave Stevenson dave.stevenson@raspberrypi.com

---

drivers/gpu/drm/vc4/vc4_hdmi.c | 3 +++ 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 5a608ed1d75e..a88aa20beeb6 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -796,6 +796,9 @@ static int vc4_hdmi_encoder_atomic_check(struct drm_encoder *encoder, pixel_rate = mode->clock * 1000; }

•   if (mode->flags & DRM_MODE_FLAG_DBLCLK)
  

•           pixel_rate = pixel_rate * 2;
  

•   if (pixel_rate > vc4_hdmi->variant->max_pixel_clock)
            return -EINVAL;
  
  

-- 2.28.0