Re: [PATCH] drm/qxl: lost qxl_bo_kunmap_atomic_page in qxl_image_init_helper()

On Mon, Apr 27, 2020 at 10:55:27AM +0300, Vasily Averin wrote:

Signed-off-by: Vasily Averin vvs@virtuozzo.com

drivers/gpu/drm/qxl/qxl_image.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/qxl/qxl_image.c b/drivers/gpu/drm/qxl/qxl_image.c index 43688ecdd8a0..7270da62fc29 100644 --- a/drivers/gpu/drm/qxl/qxl_image.c +++ b/drivers/gpu/drm/qxl/qxl_image.c @@ -212,6 +212,7 @@ qxl_image_init_helper(struct qxl_device *qdev, break; default: DRM_ERROR("unsupported image bit depth\n");

• qxl_bo_kunmap_atomic_page(qdev, image_bo, ptr);
  

  return -EINVAL; /* TODO: cleanup */

I guess you can ditch the TODO comment now, it's done ;)

take care, Gerd