Re: [PATCH 13/16] drm/omap: use u32 instead of enum omap_color_mode

On 24/05/17 13:28, Laurent Pinchart wrote:

Hi Tomi,

Thank you for the patch.

On Thursday 04 May 2017 13:23:29 Tomi Valkeinen wrote:

...

In this step we drop 'enum omap_color_mode', and use u32 instead.

Signed-off-by: Tomi Valkeinen tomi.valkeinen@ti.com

I believe this should go before 12/16, otherwise you end up temporarily storing DRM_FORMAT_* values in enum omap_color_mode variables.

That's on purpose, I mention it in the previous patch. Do you see a problem with it?

If I change the order, then I'd be going back and forth with u32 and enum omap_color_mode.

But I could squash this and 12 together. That's perhaps the technically most correct option, but I wanted to split the changes into a bit smaller pieces.

Tomi