Re: [PATCH v2 2/3] dt-bindings: display: panel: Convert sitronix,st7701 to DT schema

On Wed, Mar 18, 2020 at 11:10 AM Jagan Teki jagan@amarulasolutions.com wrote:

Convert the sitronix,st7701 panel bindings to DT schema.

Signed-off-by: Jagan Teki jagan@amarulasolutions.com

Changes for v2:

• fix dt_binding_check

.../display/panel/sitronix,st7701.txt | 30 -------- .../display/panel/sitronix,st7701.yaml | 68 +++++++++++++++++++ 2 files changed, 68 insertions(+), 30 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt create mode 100644 Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt b/Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt deleted file mode 100644 index ccd17597f1f6..000000000000 --- a/Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt +++ /dev/null @@ -1,30 +0,0 @@ -Sitronix ST7701 based LCD panels

-ST7701 designed for small and medium sizes of TFT LCD display, is -capable of supporting up to 480RGBX864 in resolution. It provides -several system interfaces like MIPI/RGB/SPI.

-Techstar TS8550B is 480x854, 2-lane MIPI DSI LCD panel which has -inbuilt ST7701 chip.

-Required properties: -- compatible: must be "sitronix,st7701" and one of

• • "techstar,ts8550b"

-- reset-gpios: a GPIO phandle for the reset pin

-Required properties for techstar,ts8550b: -- reg: DSI virtual channel used by that screen -- VCC-supply: analog regulator for MIPI circuit -- IOVCC-supply: I/O system regulator

-Optional properties: -- backlight: phandle for the backlight control.

-panel@0 {

•   compatible = "techstar,ts8550b", "sitronix,st7701";
  

•   reg = <0>;
  

•   VCC-supply = <&reg_dldo2>;
  

•   IOVCC-supply = <&reg_dldo2>;
  

•   reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
  

•   backlight = <&backlight>;
  

-}; diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml b/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml new file mode 100644 index 000000000000..e02686dfd937 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0+ OR X11)

Do you have rights on the old doc to change the license? If so, it should be:

(GPL-2.0-only OR BSD-2-Clause)

If not, GPL-2.0-only.

+%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/sitronix,st7701.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Sitronix ST7701 based LCD panels

+maintainers:

• • Jagan Teki jagan@amarulasolutions.com

+description: |

• ST7701 designed for small and medium sizes of TFT LCD display, is
• capable of supporting up to 480RGBX864 in resolution. It provides
• several system interfaces like MIPI/RGB/SPI.
• Techstar TS8550B is 480x854, 2-lane MIPI DSI LCD panel which has
• inbuilt ST7701 chip.

Reference panel-common.yaml here.

+properties:

• compatible:
• items:

•  - enum:
  

•      - techstar,ts8550b
  

•  - const: sitronix,st7701
  

• reg:
• description: DSI virtual channel used by that screen

maxItems: 1

• VCC-supply:
• description: analog regulator for MIPI circuit
• IOVCC-supply:
• description: I/O system regulator
• reset-gpios:
• description: a GPIO phandle for the reset pin

Just 'reset-gpios: true'. Already defined by panel-common.yaml.

• backlight:
• description: Backlight used by the panel
• $ref: "/schemas/types.yaml#/definitions/phandle"

Same here. Just need 'true'.

+required:

• • compatible
• • reg
• • VCC-supply
• • IOVCC-supply
• • reset-gpios

+additionalProperties: false

+examples:

• • |
• #include <dt-bindings/gpio/gpio.h>
• dsi {

•    #address-cells = <1>;
  

•    #size-cells = <0>;
  

•    panel@0 {
  

•        compatible = "techstar,ts8550b", "sitronix,st7701";
  

•        reg = <0>;
  

•        VCC-supply = <&reg_dldo2>;
  

•        IOVCC-supply = <&reg_dldo2>;
  

•        reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
  

•        backlight = <&backlight>;
  

•    };
  

• };

-- 2.17.1