Re: [PATCH v1 01/11] soc: mediatek: cmdq: add address shift in jump

Reviewed-by: Bibby Hsieh bibby.hsieh@mediatek.com

Thanks.

On Sun, 2020-06-21 at 22:18 +0800, Dennis YC Hsieh wrote:

Add address shift when compose jump instruction to compatible with 35bit format.

Signed-off-by: Dennis YC Hsieh dennis-yc.hsieh@mediatek.com

drivers/soc/mediatek/mtk-cmdq-helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c index c67081759728..98f23ba3ba47 100644 --- a/drivers/soc/mediatek/mtk-cmdq-helper.c +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c @@ -291,7 +291,8 @@ static int cmdq_pkt_finalize(struct cmdq_pkt *pkt)

/* JUMP to end */ inst.op = CMDQ_CODE_JUMP;

• inst.value = CMDQ_JUMP_PASS;

• inst.value = CMDQ_JUMP_PASS >>

• cmdq_mbox_shift(((struct cmdq_client *)pkt->cl)->chan);
  

  err = cmdq_pkt_append_command(pkt, inst);

  return err;