Re: [PATCH v5 2/2] drm/lima: driver for ARM Mali4xx GPUs

Hi Sam,

Thanks, I'll fix them in next version.

Regards, Qiang

On Sun, Mar 3, 2019 at 11:02 PM Sam Ravnborg sam@ravnborg.org wrote:

Hi Qiang.

Good to see you do prompt follow-up on the feedback you get. I applied the patch and noticed that git compains about a few whitespace errors. So for good measure I throw checkpatch after it. $ scripts/checkpatch.pl --max-line-length=120 ~/lima

...
total: 45 errors, 36 warnings, 4197 lines checked

Several (most) of these looks like legitimate issues and should be fixed. It is much easier to do it now, rather than handle the trivial patches later.

    Sam