Re: [PATCH 2/2] drm/meson: encoder_hdmi: Fix refcount leak in meson_encoder_hdmi_init

Hello,

first of all: thank you for spotting this and sending a patch!

On Tue, May 31, 2022 at 4:49 PM Miaoqian Lin linmq006@gmail.com wrote: [...]

diff --git a/drivers/gpu/drm/meson/meson_encoder_hdmi.c b/drivers/gpu/drm/meson/meson_encoder_hdmi.c index 5e306de6f485..f3341458f8b7 100644 --- a/drivers/gpu/drm/meson/meson_encoder_hdmi.c +++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.c @@ -363,6 +363,7 @@ int meson_encoder_hdmi_init(struct meson_drm *priv) }

    meson_encoder_hdmi->next_bridge = of_drm_find_bridge(remote);

•   of_node_put(remote);
  

further down in the same function remote is used again: pdev = of_find_device_by_node(remote);

My understanding is that we should only use of_node_put() once we don't need to access the node (in this case the variable is "remote") anymore.

Best regards, Martin