On Wed, Oct 9, 2019 at 6:31 PM Rob Herring robh@kernel.org wrote:
On Tue, Oct 01, 2019 at 06:39:22PM -0500, Adam Ford wrote:
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display.
Signed-off-by: Adam Ford aford173@gmail.com
V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 V3: Correct build errors from 'make dt_binding_check'
The example still fails to build here.
I cannot replicate the build error on 5.4-RC3 at least for this binding on V4 of the patch. I get build error on other bindings.
$ make dt_binding_check ARCH=arm scripts/kconfig/conf --syncconfig Kconfig SCHEMA Documentation/devicetree/bindings/processed-schema.yaml /home/aford/src/linux/Documentation/devicetree/bindings/net/adi,adin.yaml: ignoring, error in schema 'adi,rx-internal-delay-ps' warning: no schema found in file: Documentation/devicetree/bindings/net/adi,adin.yaml /home/aford/src/linux/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml: ignoring, error in schema '0' warning: no schema found in file: Documentation/devicetree/bindings/regulator/fixed-regulator.yaml CHKDT Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml .... CHKDT Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml CHKDT Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml CHKDT Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml CHKDT Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml ... CHKDT Documentation/devicetree/bindings/media/allwinner,sun4i-a10-ir.yaml CHKDT Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml: $id: path/filename 'arm/allwinner,sun4i-a10-csi.yaml' doesn't match actual filename Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts] Error 1 Makefile:1263: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2
I took out some of the logs to make it less chatty. I don't know anything about yaml or what the expectations are, so if there is a test beyond 'make dt_binding_check' please let me know.
Thank you,
adam
V2: Use YAML instead of TXT for binding
diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file mode 100644 index 000000000000..e2c62e8f1db4 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Logic PD Type 28 4.3" WQVGA TFT LCD panel
+maintainers:
- Adam Ford aford173@gmail.com
+allOf:
- $ref: panel-common.yaml#
+properties:
- compatible:
- const: logicpd,type28
- power-supply: true
- enable-gpios: true
- backlight: true
- port: true
+required:
- compatible
+additionalProperties: false
+examples:
- |
- lcd0: display {
compatible = "logicpd,type28";enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>;backlight = <&backlight>;port {lcd_in: endpoint {remote-endpoint = <&dpi_out>;};};- };
+...
2.17.1