Hi Daniel,
On Tue, Jun 02, 2020 at 11:51:39AM +0200, Daniel Vetter wrote:
This is already done as part of the drm_atomic_helper_shutdown(), and in that case only for the crtc which are actually on.
I'm pretty sure that it didn't used to be the case when I wrote the code and I was hitting warnings from 84014b0a39eef6df ("drm/atomic-helper: check that drivers call drm_crtc_vblank_off"), but I'm happy that things have now been fixed.
Signed-off-by: Daniel Vetter daniel.vetter@intel.com Cc: Liviu Dudau liviu.dudau@arm.com
Acked-by: Liviu Dudau liviu.dudau@arm.com
Best regards, Liviu
Cc: Brian Starkey brian.starkey@arm.com Cc:
drivers/gpu/drm/arm/malidp_drv.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index 02904392e370..db6ba5c78042 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -928,7 +928,6 @@ static void malidp_unbind(struct device *dev) drm_dev_unregister(drm); drm_kms_helper_poll_fini(drm); pm_runtime_get_sync(dev);
- drm_crtc_vblank_off(&malidp->crtc); malidp_se_irq_fini(hwdev); malidp_de_irq_fini(hwdev); drm->irq_enabled = false;
-- 2.26.2