Re: [Intel-gfx] [PATCH v5 2/7] drm: add parameter-order checking to drm memory allocators

On Mon, Feb 29, 2016 at 04:16:57PM +0000, Tvrtko Ursulin wrote:

i915 cleanups are good but I am unsure of whether it is good to add this constant constraints. All current code seems to use it like that, true, but I am not sure that it should be a requirement.

The drm_mem_util allocators are written under that presumption in order to allow gcc to do some constant-expression elimination - but obviously that is not strictly required.

I like the assertions, they help describe the API and should allow us to warn about potential bugs. -Chris