Re: [PATCH v7 12/12] drm/vc4: hdmi: Remove clock rate initialization

Am 25.02.22 um 15:35 schrieb Maxime Ripard:

Now that the clock driver makes sure we never end up with a rate of 0, the HDMI driver doesn't need to care anymore.

Signed-off-by: Maxime Ripard maxime@cerno.tech

Acked-by: Thomas Zimmermann tzimmermann@suse.de

---

drivers/gpu/drm/vc4/vc4_hdmi.c | 13 ------------- 1 file changed, 13 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 92b1530aa17b..21aff3ad96cf 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -2576,19 +2576,6 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data) vc4_hdmi->disable_4kp60 = true; }

• /*

• * If we boot without any cable connected to the HDMI connector,
  

• * the firmware will skip the HSM initialization and leave it
  

• * with a rate of 0, resulting in a bus lockup when we're
  

• * accessing the registers even if it's enabled.
  

• *
  

• * Let's put a sensible default at runtime_resume so that we
  

• * don't end up in this situation.
  

• */
  

• ret = clk_set_min_rate(vc4_hdmi->hsm_clock, HSM_MIN_CLOCK_FREQ);
• if (ret)

• goto err_put_ddc;
  

• /*
  • We need to have the device powered up at this point to call
  • our reset hook and for the CEC init.